Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9666 )
Change subject: inter-BSC HO: add neighbor_ident API to manage neighbor-BSS-cells ...................................................................... Patch Set 3: (5 comments) https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/gsm_data.h@755 PS3, Line 755: struct gsm_bts_ref { > not a request to change, just a general reminder: We also have the "vector" > of libosmovty, which is […] ah. I thought the vector was a string parsing specific implementation, now I see it's sort of like the C++ vector... with vector the allocation dance is slightly more complex to code, though it has a better memory footprint. Though if you say not a request to change, then I'll not change it. https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/neighbor_ident.h File include/osmocom/bsc/neighbor_ident.h: https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/neighbor_ident.h@18 PS3, Line 18: BSIC_9BIT, > huh, where's that 9 bit BSIC coming from? Do you have a spec reference for me? 23.003 "4.3.2 Base Station Identify Code (BSIC)" says: "BSIC is a 6 bit code which is structured as shown in Figure 6. Exceptions apply to networks supporting EC-GSM-IoT or PEO and for mobile stations in EC or PEO operation (see 3GPP TS 43.064 [112]) where the BSIC is a 9 bit code which is structured as shown in Figure 6a." Let me guess, EC-GSM-IoT or PEO (which i haven't a clue about) doesn't apply and we can cut out the entire 9-bit bsic enum? I think I just saw the 6-or-9-bit BSIC encoding somewhere, like in a message coding chapter, and thought it was safer to allow both from the start... https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/gsm_data.c File src/osmo-bsc/gsm_data.c: https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/gsm_data.c@567 PS3, Line 567: bool gsm_bts_matches_cell_id(struct gsm_bts *bts, const struct gsm0808_cell_id *ci) > not important, but I'd expect 'bts' could also be a const pointer, as we're > just reading/comparing/m […] I wonder why I wouldn't have consted that... maybe it was copy-pasted from a more potent function. Ah, I see now that I'm actually changing it again in the "large refactoring commit", will move that part here. https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/neighbor_ident_vty.c File src/osmo-bsc/neighbor_ident_vty.c: https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/neighbor_ident_vty.c@560 PS3, Line 560: install_element(BTS_NODE, &cfg_neighbor_resolve_cmd); > the BTS_NODE is a sub-node of the CONFIG NODE. […] hm, so when I'm in the bts node and entered some neighbor entries, I can't just query on the same level but I should prepend 'do bts <nr>'? I understand the scoping aspect, wasn't aware that it's that strict though. Ok, so how about 'show bts NR neighbor NEIGHBOR_IDENT_VTY_KEY_PARAMS'. https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c File tests/handover/neighbor_ident_test.c: https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c@33 PS3, Line 33: arfcn > it might be interesting to have test cases for ARFCNs in different bands. […] In turn I'm not fully understanding yet where the pitfall lies in that. Here, I'm simply using arfcn as a 16bit key, and the high bit is simply the high bit in that number space. Should it imply some special meaning and/or affect other data fields? -- To view, visit https://gerrit.osmocom.org/9666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0153d7069817fba9146ddc11214de2757d7d37bf Gerrit-Change-Number: 9666 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 22:06:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
