Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9666 )
Change subject: inter-BSC HO: add neighbor_ident API to manage neighbor-BSS-cells ...................................................................... Patch Set 12: (2 comments) https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/neighbor_ident.h File include/osmocom/bsc/neighbor_ident.h: https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/neighbor_ident.h@18 PS3, Line 18: BSIC_9BIT, > Ah, I didn't follow EC-GSM-IoT yet in that level of detail. […] yeah, I think I'll just drop the 9-bit stuff then, in a way that doesn't prevent us from re-adding it later, in the unlikely event. https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c File tests/handover/neighbor_ident_test.c: https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c@33 PS3, Line 33: arfcn > The User Interface and VTY is 0-1023. There are no higher ARFCN number. […] Leaving for the future then, but I still haven't grokked where the 0x8000 is coming from. Is it osmocom code using this bit or 3GPP protocol we are receiving? -- To view, visit https://gerrit.osmocom.org/9666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0153d7069817fba9146ddc11214de2757d7d37bf Gerrit-Change-Number: 9666 Gerrit-PatchSet: 12 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 26 Jul 2018 00:59:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
