Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9666 )
Change subject: inter-BSC HO: add neighbor_ident API to manage neighbor-BSS-cells ...................................................................... Patch Set 3: (4 comments) https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/gsm_data.h@755 PS3, Line 755: struct gsm_bts_ref { > ah. […] not a request, just a reminder for future cases. https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/neighbor_ident.h File include/osmocom/bsc/neighbor_ident.h: https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/neighbor_ident.h@18 PS3, Line 18: BSIC_9BIT, > 23.003 "4.3.2 Base Station Identify Code (BSIC)" […] Ah, I didn't follow EC-GSM-IoT yet in that level of detail. We don't support it (and it seems like it's becoming one of the "born dead" inventions of the GSM/3GPP specs). We don't deal with a 9bit BSIC in any other part of the code in BTS or BSC, so it might be offering options/choices to people that are more confusing than helping. Your call. Either keep it in, or #ifdef it out? https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/neighbor_ident_vty.c File src/osmo-bsc/neighbor_ident_vty.c: https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/neighbor_ident_vty.c@560 PS3, Line 560: install_element(BTS_NODE, &cfg_neighbor_resolve_cmd); > hm, so when I'm in the bts node and entered some neighbor entries, I can't > just query on the same le […] yes, this separation about VIEW/ENABLE and CONFIG node exists. prefixing it with "show" is of course always an option, as long as it's in the VIEW/ENABLE node. https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c File tests/handover/neighbor_ident_test.c: https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c@33 PS3, Line 33: arfcn > In the C API to neighbor_ident, the high bit should be handled transparently. > […] The User Interface and VTY is 0-1023. There are no higher ARFCN number. But the semantics of [some of that] number space differs whether the neighbor is in DCS or in PCS bands. I don't know the specs well enough to understand how they differentiate neighbors between those two bands. However, there are (supported) setups of our customers that either use 900+1800 (more standard) or (AFAIK) 900+1900 (!) MHz bands. Maybe this can be re-visited as a separate follow-up ticket, unrelated to the specific test case: Ensure that our neighbor-handling works correctly with neighbors in either DCS or PCS bands. -- To view, visit https://gerrit.osmocom.org/9666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0153d7069817fba9146ddc11214de2757d7d37bf Gerrit-Change-Number: 9666 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 24 Jul 2018 05:06:35 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
