Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9666 )

Change subject: inter-BSC HO: add neighbor_ident API to manage 
neighbor-BSS-cells
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c
File tests/handover/neighbor_ident_test.c:

https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c@33
PS3, Line 33: arfcn
> Leaving for the future then, but I still haven't grokked where the 0x8000 is 
> coming from. […]
The 0x8000 is osmocom specific representation of ARFCN numbers with PCS band.  
It was first introduced in OsmcoomBB, AFAIR.

In 3GPP, AFAIK, the ARFCN number is always only 10 bits, and the context will 
tell you if it's PCS or not.  Or, maybe, in some instances an external bit 
somewhere.



--
To view, visit https://gerrit.osmocom.org/9666
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0153d7069817fba9146ddc11214de2757d7d37bf
Gerrit-Change-Number: 9666
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Comment-Date: Fri, 27 Jul 2018 15:49:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to