Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9666 )
Change subject: inter-BSC HO: add neighbor_ident API to manage neighbor-BSS-cells ...................................................................... Patch Set 12: (1 comment) still need to resolve the 0x8000 ARFCN bit question... https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c File tests/handover/neighbor_ident_test.c: https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c@33 PS3, Line 33: arfcn > In turn I'm not fully understanding yet where the pitfall lies in that. […] In the C API to neighbor_ident, the high bit should be handled transparently. But I notice that in the VTY we are limiting ARFCN args to <0-1023>. Should we set 0x8000 depending on the band the BTS operates on, and if yes, also in the user visible interface, or is it possible to derive it interally? -- To view, visit https://gerrit.osmocom.org/9666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0153d7069817fba9146ddc11214de2757d7d37bf Gerrit-Change-Number: 9666 Gerrit-PatchSet: 12 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 23 Jul 2018 01:12:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
