Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11954 )
Change subject: bsc: timeslot_fsm: Fix ts_is_lchan_waiting_for_pchan ...................................................................... Patch Set 5: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11954/5/src/osmo-bsc/timeslot_fsm.c File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/#/c/11954/5/src/osmo-bsc/timeslot_fsm.c@894 PS5, Line 894: return true; Don't drop below 'case'. Imagine an lchan requested to be set up, then the conn failed or what, and the lchan is gone again. Then the TS is already busy switching, and must complete that dance. It will likely go right back to PDCH once it reached the unused state, but so far it is actually switching to NONE. It's an obscure case, but don't assume that it never happens. -- To view, visit https://gerrit.osmocom.org/11954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib03e5a91438a5b74a04e69f81fab565842b02b66 Gerrit-Change-Number: 11954 Gerrit-PatchSet: 5 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Assignee: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 29 Nov 2018 19:06:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
