Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11954 )
Change subject: bsc: timeslot_fsm: Fix ts_is_lchan_waiting_for_pchan ...................................................................... Patch Set 6: (2 comments) I think the comments and the for_each change belong together, since the change in behavior in the for_each section means it's not longer true an "lchan would be waiting" as stated in the old comment. https://gerrit.osmocom.org/#/c/11954/6/src/osmo-bsc/timeslot_fsm.c File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/#/c/11954/6/src/osmo-bsc/timeslot_fsm.c@890 PS6, Line 890: /* If we were switching to PDCH, there's no PDCH lchan managed > there is no thing as a "PDCH lchan" That's exactly what I'm saying here, for people reading this code which may have not gone through all code base to understand this kind of stuff. I was there and I would have liked to know this kind of information more easily. https://gerrit.osmocom.org/#/c/11954/6/src/osmo-bsc/timeslot_fsm.c@891 PS6, Line 891: * in BSC, So we need to set it manually. */ > "in BSC", i.e. "here"? […] yes, here, in BSC. It explains people it's not in the BSC because it's handled somewhere else: the PCU. -- To view, visit https://gerrit.osmocom.org/11954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib03e5a91438a5b74a04e69f81fab565842b02b66 Gerrit-Change-Number: 11954 Gerrit-PatchSet: 6 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Assignee: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 16:47:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
