Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11954 )
Change subject: bsc: timeslot_fsm: Fix ts_is_lchan_waiting_for_pchan ...................................................................... Patch Set 7: (2 comments) I still think the one part fixes how it works, and the other just clarifies comments, without changing the meaning of the comments. To me clearly separate changes... https://gerrit.osmocom.org/#/c/11954/6/src/osmo-bsc/timeslot_fsm.c File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/#/c/11954/6/src/osmo-bsc/timeslot_fsm.c@890 PS6, Line 890: /* If we were switching to PDCH, there's no PDCH lchan managed > That's exactly what I'm saying here, for people reading this code which may > have not gone through al […] the way I read it, it implies that "there is a PDCH lchan, but it is not managed here". Also when doing PDCH_ACT, we simply and plainly are switching to PDCH, there isn't even an lchan involved. We're switching *because* all lchans are gone. And always to PDCH, as the code aptly shows. Nothing to do with "manual" or "PDCH lchans" :P https://gerrit.osmocom.org/#/c/11954/6/src/osmo-bsc/timeslot_fsm.c@891 PS6, Line 891: * in BSC, So we need to set it manually. */ > yes, here, in BSC. […] can we rephrase it so it still helps future readers while it doesn't make me twitch? When switching to PDCH, there are no lchans and we are telling the PCU to take over the timeslot. ? -- To view, visit https://gerrit.osmocom.org/11954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib03e5a91438a5b74a04e69f81fab565842b02b66 Gerrit-Change-Number: 11954 Gerrit-PatchSet: 7 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Assignee: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 17:19:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
