Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11954 )
Change subject: bsc: timeslot_fsm: Fix ts_is_lchan_waiting_for_pchan ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/11954/5/src/osmo-bsc/timeslot_fsm.c File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/#/c/11954/5/src/osmo-bsc/timeslot_fsm.c@894 PS5, Line 894: return true; > Don't drop below 'case'. […] Ok makes sense. But then I'll submit an extra patch setting correctly for IPA dynTS too: case TS_ST_WAIT_PDCH_DEACT: if (target_pchan) *target_pchan = pchan_on_init == OSMO ? GSM_PCHAN_NONE : GSM_PCHAN_TCH_F; return true; -- To view, visit https://gerrit.osmocom.org/11954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib03e5a91438a5b74a04e69f81fab565842b02b66 Gerrit-Change-Number: 11954 Gerrit-PatchSet: 5 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Assignee: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 30 Nov 2018 17:28:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
