Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11954 )
Change subject: bsc: timeslot_fsm: Fix ts_is_lchan_waiting_for_pchan ...................................................................... Patch Set 6: Code-Review-1 (2 comments) please submit the for_each fix separately and go ahead and +2 right away. About the comments, I think the first comment isn't saying anything. The second comment is a nice clarification compared to the old one. https://gerrit.osmocom.org/#/c/11954/6/src/osmo-bsc/timeslot_fsm.c File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/#/c/11954/6/src/osmo-bsc/timeslot_fsm.c@890 PS6, Line 890: /* If we were switching to PDCH, there's no PDCH lchan managed there is no thing as a "PDCH lchan" https://gerrit.osmocom.org/#/c/11954/6/src/osmo-bsc/timeslot_fsm.c@891 PS6, Line 891: * in BSC, So we need to set it manually. */ "in BSC", i.e. "here"? I don't get this comment at all :) -- To view, visit https://gerrit.osmocom.org/11954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib03e5a91438a5b74a04e69f81fab565842b02b66 Gerrit-Change-Number: 11954 Gerrit-PatchSet: 6 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Assignee: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 16:41:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
