Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12226 )
Change subject: Add tests for IMSI ACLs ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c File tests/sgsn/sgsn_test.c: https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c@1343 PS2, Line 1343: size_t old = sgsn_acl_count(cfg), new; This line is suuuuuper ugly, mixing declaration, initialization and function call. https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c@1374 PS2, Line 1374: size_t old = sgsn_acl_count(cfg), new; same https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c@1383 PS2, Line 1383: printf("failed to remove acl %s, total entries %zu\n", imsi, sgsn_acl_count(cfg)); You can use "new" here instead of sgsn_acl_count(cfg) -- To view, visit https://gerrit.osmocom.org/12226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia782f12b49bed6428bc9b9f513237e4e6aefdec9 Gerrit-Change-Number: 12226 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 10 Dec 2018 16:02:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
