Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12226 )
Change subject: Add tests for IMSI ACLs ...................................................................... Patch Set 5: (2 comments) I'm kind of puzzled how the ACL is even relevant anymore after we're using osmo-hlr? https://gerrit.osmocom.org/#/c/12226/5/tests/sgsn/sgsn_test.c File tests/sgsn/sgsn_test.c: https://gerrit.osmocom.org/#/c/12226/5/tests/sgsn/sgsn_test.c@1348 PS5, Line 1348: size_t new_count, old_count = sgsn_acl_count(cfg); prefer each variable on its own line. (kind of unnecessary to go yet another review cycle after Pau has spelled it out in detail.) https://gerrit.osmocom.org/#/c/12226/5/tests/sgsn/sgsn_test.c@1379 PS5, Line 1379: size_t new_count, old_count = sgsn_acl_count(cfg); same -- To view, visit https://gerrit.osmocom.org/12226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia782f12b49bed6428bc9b9f513237e4e6aefdec9 Gerrit-Change-Number: 12226 Gerrit-PatchSet: 5 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-CC: Neels Hofmeyr <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Tue, 11 Dec 2018 12:37:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
