Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12226 )
Change subject: Add tests for IMSI ACLs ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c File tests/sgsn/sgsn_test.c: https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c@1343 PS2, Line 1343: size_t old = sgsn_acl_count(cfg), new; > > while having another variable after calling the function separate by a > > comma […] I'd like you to clean the line, I think it's pretty obvious. Either: " size_t old_count, new_count; int rc; old_count = sgsn_acl_count(cfg); " or " int rc; size_t old_count; size_t new_count = sgsn_acl_count(cfg); " -- To view, visit https://gerrit.osmocom.org/12226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia782f12b49bed6428bc9b9f513237e4e6aefdec9 Gerrit-Change-Number: 12226 Gerrit-PatchSet: 2 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Tue, 11 Dec 2018 11:51:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
