Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12226 )
Change subject: Add tests for IMSI ACLs ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c File tests/sgsn/sgsn_test.c: https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c@1343 PS2, Line 1343: } > Doing these stuff while having another variable after calling the function > separate by a comma? Let […] May I suggest a variable name change: old_count and new_count? -- To view, visit https://gerrit.osmocom.org/12226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia782f12b49bed6428bc9b9f513237e4e6aefdec9 Gerrit-Change-Number: 12226 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Mon, 10 Dec 2018 19:21:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
