Max has posted comments on this change. ( https://gerrit.osmocom.org/12226 )
Change subject: Add tests for IMSI ACLs ...................................................................... Patch Set 5: (1 comment) Please keep comments constructive and actionable - things like "suuuuuper ugly" does not convey much meaning. https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c File tests/sgsn/sgsn_test.c: https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c@1343 PS2, Line 1343: } > while having another variable after calling the function separate by a comma Ah, so you want me to change the order of variable? Than please say so. -- To view, visit https://gerrit.osmocom.org/12226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia782f12b49bed6428bc9b9f513237e4e6aefdec9 Gerrit-Change-Number: 12226 Gerrit-PatchSet: 5 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Tue, 11 Dec 2018 10:34:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
