Junio C Hamano <gits...@pobox.com> writes:

> "David A. Greene" <gree...@obbligato.org> writes:
>> From: Techlive Zheng <techlivezh...@gmail.com>
>> Use %B to format the commit message and body to avoid an extra newline
>> if a commit only has a subject line.
> Is this an unconditional improvement, or is it generally an
> improvement but for some users it may be a regression?  I am
> guessing it is the former but am just making sure.

The former.

>> Author:    Techlive Zheng <techlivezh...@gmail.com>
>> Signed-off-by: David A. Greene <gree...@obbligato.org>
> Please don't do "Author: " which does not add anything new.  That is
> what "From: " is for.  Instead it needs to be a sign-off.

Ok.  Unfortunately I sent a number of patches like that.  Do you want me
to re-send them?

> Also, is that a real name, I have to wonder?

No idea.  Not likely, I'd say.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to