Le 22/01/2013 05:31, Junio C Hamano a écrit :
Jeff King <p...@peff.net>  writes:
>> I really hate to suggest this, but should it be more like:
>> if test -z "$FAKE_COMMAND_LIST"; then __git_cmdlist() { git help -a
>> | egrep '^ [a-zA-Z0-9]' } else __git_cmdlist() { printf '%s'
>> That gives us a nice predictable starting point for actually
>> testing the completion code. The downside is that it doesn't let
>> us test that we remain compatible with the output of "help -a".
> Yeah, I think this is simpler and more to the point for the test in
> t9902. If we really want to test something that is the same as, or
> at least any closer than this approach (or my "help --standard"), to
> what the real users use, the test has to become inherently flaky, so
> I think we should go for the simplicity of this patch shows.

Instead of imposing the list of command, we could use the command
list argument to filter the ouput of git help -a. This would ensure that the
completions we want to test are still present in the installation while
still restricting them to the test case.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to