On Fri, Apr 26, 2013 at 1:53 PM, Ramkumar Ramachandra
<artag...@gmail.com> wrote:
> Felipe Contreras wrote:
>> What is your objective, do you want to help this project move forward or not?
> Forward, please.
> I want a solution to this persistent problem of conflict though.  And
> I presented one in my previous email:
> Here's my solution to the problem: maintain your project outside
> git.git and merge changes in every couple of months or so with a
> simple email containing a pull URL, addressing Junio.  If Junio trusts
> you enough to put the changes you send into contrib/ after a cursory
> glance, we're done.  Start a separate mailing list for your project/
> accept GitHub pull requests via which contributors can send you
> changes.  No more fuss or drama on the git list about this.  You can
> be as stubborn as you want, and we go back to our lives.  Everyone
> wins.

I already maintain my own clone outside of git.git[1], and I do
already accept pull requests[2], and people have sent me patches
directly. The stuff I send to the git mailing list is what I think is
ready for merging. But there's only so much stuff I can catch.

We all benefit from these patches being reviewed in the git mailing
list, nobody has claimed otherwise. You are making the error of
assuming that your review was actionable, that I should have done
something, fix the commit message I suppose, but I don't think that's

In contrast, this is how a constructive, valid and helpful review looks like:


Junio caught a problem I didn't see, I accepted the valid feedback,
and I resent with a fix. We all benefit from such interactions, both
users, and developers. What's wrong with that?

You just got angry that your review didn't turn out to be helpful, is
that it? Why do you want to steal helpful review from the users of
remote-{bzr,hg}? If that's not the case, please stop doing that. All
review is welcome, not all review should be acted upon.


[1] https://github.com/felipec/git

Felipe Contreras
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to