Felipe Contreras <felipe.contre...@gmail.com> writes:

>> I think we heard enough from packaging folks that a new dependency
>> is unwelcome.
> What are you talking about? Which are these "packaging folks" we heard from?

Dscho is one of the primary people behind msysgit effort, and I
consulted with others from the circle with an draft before I sent
the message to the list for sanity checking (fearing that I may be
worrying about adding new dependencies needlessly).  Jonathan
packages git for Debian and he is negative on adding new dependency
needlessly. It was unexpected that we hear from a pkgsrc person but
the response was also negative.

>> Also we heard from no regular/high-value reviewers
>> that they feel comfortable reviewing additions in Ruby.
> Correction; *current* regular/high-value reviewers.

That is exactly what I meant.

The code review is not only about following best practices in the
implementation language.  If somebody who is an expert in a language
we do not currently depend on, but who does not know how the parts
of Git are supposed to fit together enough to judge the soundness of
the design of new code written in that new language, or does not
know how the tests, documentation and log messages are supposed to
written around here, that person cannot be the only reviewer for
changes written in that language to ensure quality standard.

The reviewer pool for code written in a new language _must_ be
seeded by some from the current set of reviewers whose judgement
I/we can trust.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to