Hi Duy,

On Wed, 4 Jun 2014, Duy Nguyen wrote:

> On Wed, Jun 4, 2014 at 6:47 PM, Stepan Kasal <ka...@ucw.cz> wrote:
> > @@ -133,7 +133,7 @@ char *git_path(const char *fmt, ...)
> >  void home_config_paths(char **global, char **xdg, char *file)
> >  {
> >         char *xdg_home = getenv("XDG_CONFIG_HOME");
> > -       char *home = getenv("HOME");
> > +       const char *home = get_home_directory();
> >         char *to_free = NULL;
> >
> >         if (!home) {
> Just checking. Instead of replace the call sites, can we check and
> setenv("HOME") if it's missing instead? MinGW port already replaces
> main(). Extra initialization should not be a problem. I feel
> "getenv("HOME")" a tiny bit more familiar than get_home_directory(),
> but that's really weak argument as the number of call sites has not
> increased in 4 years.

There is a good reason why we did not go for that (noticably cheaper)
solution. In fact, it used to be our solution until too many things got
broken by setting the HOME variable: Git is not the only program making
use of that variable (and IIRC Putty or a merge helper got seriously
confused when we set it).

So I am afraid, no, we cannot simply setenv(HOME).

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to