gemmellr commented on code in PR #4540:
URL: https://github.com/apache/activemq-artemis/pull/4540#discussion_r1255783192
##########
artemis-hawtio/artemis-console/pom.xml:
##########
@@ -55,18 +55,6 @@
<version>${hawtio.version}</version>
<scope>provided</scope>
</dependency>
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- <!-- License: Apache 2.0 -->
- <!-- see https://github.com/google/guava/issues/3006:
checker-compat-qual could be excluded -->
- <exclusions>
- <exclusion>
- <groupId>org.checkerframework</groupId>
- <artifactId>checker-compat-qual</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
Review Comment:
Right...Guava isnt there, but is is meant to be there. Note its dependencies
still being present.
The exclusion I mentioned earlier, in the repackaging the module build does,
removed the version the original war included. You have removed the dependency
that lead to its replacement in the repackaged war.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
