gemmellr commented on code in PR #4540:
URL: https://github.com/apache/activemq-artemis/pull/4540#discussion_r1255788536


##########
pom.xml:
##########
@@ -1097,6 +1094,13 @@
                               <arg>-XDcompilePolicy=simple</arg>
                               <arg>-Xplugin:ErrorProne 
-Xep:ThreadLocalUsage:ERROR -Xep:MissingOverride:ERROR 
-Xep:NonAtomicVolatileUpdate:ERROR -Xep:SynchronizeOnNonFinalField:ERROR 
-Xep:StaticQualifiedUsingExpression:ERROR -Xep:WaitNotInLoop:ERROR 
-Xep:BanJNDI:OFF -XepExcludedPaths:.*/generated-sources/.*</arg>
                           </compilerArgs>
+                          <annotationProcessorPaths>
+                              <path>
+                                  <groupId>com.google.errorprone</groupId>
+                                  <artifactId>error_prone_core</artifactId>
+                                  <version>${errorprone.version}</version>
+                              </path>
+                          </annotationProcessorPaths>

Review Comment:
   When compiling what? That looks like part of Guava, which is an Error Prone 
dependency...so did something exclude it?
   
   This change [silently] breaks the compilation [output] too, so...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to