gemmellr commented on code in PR #4540:
URL: https://github.com/apache/activemq-artemis/pull/4540#discussion_r1259992802
##########
pom.xml:
##########
@@ -1097,6 +1094,13 @@
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne
-Xep:ThreadLocalUsage:ERROR -Xep:MissingOverride:ERROR
-Xep:NonAtomicVolatileUpdate:ERROR -Xep:SynchronizeOnNonFinalField:ERROR
-Xep:StaticQualifiedUsingExpression:ERROR -Xep:WaitNotInLoop:ERROR
-Xep:BanJNDI:OFF -XepExcludedPaths:.*/generated-sources/.*</arg>
</compilerArgs>
+ <annotationProcessorPaths>
+ <path>
+ <groupId>com.google.errorprone</groupId>
+ <artifactId>error_prone_core</artifactId>
+ <version>${errorprone.version}</version>
+ </path>
+ </annotationProcessorPaths>
Review Comment:
I'd guess because it is doing a completely different thing there, with the
ErrorProne deps defined earlier off-classpath, likely meaning its transitive
guava dep version gets picked up, before starting to look at the compile deps
on the classpath...rather than the reverse in the profile case. Which is fine
if you dont remove the dependencyManagement entries ensuring the desired
versions are chosen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
