gemmellr commented on code in PR #4540:
URL: https://github.com/apache/activemq-artemis/pull/4540#discussion_r1270500400


##########
artemis-hawtio/artemis-console/pom.xml:
##########
@@ -55,18 +55,6 @@
       <version>${hawtio.version}</version>
       <scope>provided</scope>
     </dependency>
-    <dependency>
-      <groupId>com.google.guava</groupId>
-      <artifactId>guava</artifactId>
-      <!-- License: Apache 2.0 -->
-      <!-- see https://github.com/google/guava/issues/3006: 
checker-compat-qual could be excluded -->
-      <exclusions>
-        <exclusion>
-          <groupId>org.checkerframework</groupId>
-          <artifactId>checker-compat-qual</artifactId>
-        </exclusion>
-      </exclusions>
-    </dependency>

Review Comment:
   Right, the original war doesnt have it (but does have guava), so it was also 
excluded from the repackaged war to match. The original war has 
checker-qual-3.5.0.jar, which should presumably have been excluded when 
unpacking it, due to the newer guava bringing in checker-qual-3.12.0.jar



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to