gemmellr commented on code in PR #4540:
URL: https://github.com/apache/activemq-artemis/pull/4540#discussion_r1256183637
##########
pom.xml:
##########
@@ -1097,6 +1094,13 @@
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne
-Xep:ThreadLocalUsage:ERROR -Xep:MissingOverride:ERROR
-Xep:NonAtomicVolatileUpdate:ERROR -Xep:SynchronizeOnNonFinalField:ERROR
-Xep:StaticQualifiedUsingExpression:ERROR -Xep:WaitNotInLoop:ERROR
-Xep:BanJNDI:OFF -XepExcludedPaths:.*/generated-sources/.*</arg>
</compilerArgs>
+ <annotationProcessorPaths>
+ <path>
+ <groupId>com.google.errorprone</groupId>
+ <artifactId>error_prone_core</artifactId>
+ <version>${errorprone.version}</version>
+ </path>
+ </annotationProcessorPaths>
Review Comment:
>[INFO] +- org.apache.curator:curator-client:jar:5.2.0:compile
[INFO] | \- com.google.guava:guava:jar:27.0.1-jre:compile
So that module is now using Guava 27.0.1 (instead of 32.0.1 as before),
which presumably doesn't have the thing needed by ErrorProne, which normally
uses a newer version.
Maven is picking the older version during resolution, probably because
curator-client is earlier on the dependency set than the ErrorProne dep is (it
will be last due to being in a profile). Its doing that instead of just using
the specified dependencyManagement guava version that was removed from the
build. Restoring that may fix things. Alternative perhaps there is a newer
curator-client version that uses a recent guava.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
