cshannon commented on PR #1284: URL: https://github.com/apache/activemq/pull/1284#issuecomment-2313785899
One last thought on changing STOMP... I haven't looked at the exact STOMP translator in detail but I should point out that we would need to make sure we use the correct encoding depending on which direction things are going. A normal STOMP client would use regular UTF-8 encoding. So I'm wondering if this would cause extra overhead but it needs to be investigated. When sending messages to a STOMP client, we would need to decode using the ActiveMQ modified logic and then re-encode using the JDK UTF-8 version. And when receiving from a client we would need decode using the JDK standard UTF 8 version and re-encode back into bytes using the modified ActiveMQ logic so this could add an extra processing step depending on how this works. But we may not care for STOMP anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
