azotcsit commented on PR #1284:
URL: https://github.com/apache/activemq/pull/1284#issuecomment-2322958044
Thanks @cshannon!
I gave a round of testing with your fix. It seems to be working fine:
```
./bin/activemq consumer --destination queue://test --messageCount 1
INFO: Loading '/Users/alekseizotov/opt/apache-activemq-5.18.5//bin/env'
INFO: Using java '/Users/alekseizotov/opt/jdk/current/Contents/Home/bin/java'
ACTIVEMQ_HOME: /Users/alekseizotov/opt/apache-activemq-5.18.5
ACTIVEMQ_BASE: /Users/alekseizotov/opt/apache-activemq-5.18.5
ACTIVEMQ_CONF: /Users/alekseizotov/opt/apache-activemq-5.18.5/conf
ACTIVEMQ_DATA: /Users/alekseizotov/opt/apache-activemq-5.18.5/data
INFO | Connecting to URL: failover://tcp://localhost:61616 as user: null
INFO | Consuming queue://test
INFO | Sleeping between receives 0 ms
INFO | Running 1 parallel threads
INFO | Successfully connected to tcp://localhost:61616
INFO | consumer-1 wait until 1 messages are consumed
INFO | consumer-1 Received 🙃🙂
INFO | consumer-1 Consumed: 1 messages
INFO | consumer-1 Consumer thread finished
```
The current UTF-8 encoding/decoding is strictly speaking incorrect, however,
since it is consistent and encapsulated on server side (not exposed to
clients), I do not see any real harm of having it. So, I totally support the
idea of https://github.com/apache/activemq/pull/1290 fix. Thank you for doing
that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
