cshannon commented on PR #1284: URL: https://github.com/apache/activemq/pull/1284#issuecomment-2326655388
> The current UTF-8 encoding/decoding is strictly speaking incorrect, however, since it is consistent and encapsulated on server side (not exposed to clients), I do not see any real harm of having it. So, I totally support the idea of #1290 fix. Thank you for doing that! Yeah, it's definitely incorrect in terms of proper UTF-8 encoding but it still works fine as pointed out since it's encapsulated and it would be a major breaking change that would affect every OpenWire client that has been released for the last however many (probably 20+ years). I'm not against changing the encoding, but it just has to be done in a major version and a new OpenWire version. So it might be something to target for AMQ 7.x. I guess it could be done earlier if we create a new OpenWire version but seems better to just target for a major version because it's working fine as it is. The super annoying thing is that we will have to keep support for the existing non-standard/incorrect encoding no matter what in order to support older OpenWire clients if we do decide to change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
