pa-deasy opened a new pull request, #1360: URL: https://github.com/apache/activemq/pull/1360
**What problems does this PR solve?** Add test coverage to ensure socket parameters can be set for tcp and ssl connections. **Why is it beneficial to merge into ActiveMQ?** The tests provide confidence and prevent future issues like [AMQ-9473](https://issues.apache.org/jira/browse/AMQ-9473). **How do you make sure this PR is well tested?** _Test A_ Ran the two new units tests and verified success. _Test B_ Edited the `IntrospectionSupport` class to comment out the following: ``` // if (target instanceof SSLServerSocket) { // // overcome illegal access issues with internal implementation class // clazz = SSLServerSocket.class; // } else if (target instanceof javax.net.ssl.SSLSocket) { // // overcome illegal access issues with internal implementation class // clazz = javax.net.ssl.SSLSocket.class; // } ``` Ran the two new units tests and verified failure due to `java.lang.IllegalArgumentException: Invalid socket parameters`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
