pa-deasy commented on PR #1360: URL: https://github.com/apache/activemq/pull/1360#issuecomment-2523848783
> This is a good start but I think the tests could be improved. The tests show there is no more exception on connection creation which is good, but it would be nice to try setting more than one parameter and also if it's possible to access it would be good to verify the settings worked. For example, the one test sets the the ssl enabled protocols to TLSv1.3 so it would be best to assert that it did in fact apply that setting. That's a good suggestion, I've added more parameters to the unit tests. I tried verifying the parameters are in effect but it's a little difficult without exposing the `protected` `Socket` on the `TcpTransport`. I tried researching a bunch of libraries that might check the TLS version on a TCP capture but it didn't really work and would also have introduced an extra dependency. Do you have any suggestions on a better approach for verifying the socket changes? A lot of the logic resides in the JVM so it's difficult to verify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
