cshannon commented on PR #1360: URL: https://github.com/apache/activemq/pull/1360#issuecomment-2521592941
This is a good start but I think the tests could be improved. The tests show there is no more exception on connection creation which is good, but it would be nice to try setting more than one parameter and also if it's possible to access it would be good to verify the settings worked. For example, the one test sets the the ssl enabled protocols to TLSv1.3 so it would be best to assert that it did in fact apply that setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
