pa-deasy commented on code in PR #1360:
URL: https://github.com/apache/activemq/pull/1360#discussion_r1876462030
##########
activemq-unit-tests/src/test/java/org/apache/activemq/ActiveMQSslConnectionFactoryTest.java:
##########
@@ -72,6 +81,34 @@ public void testCreateTcpConnectionUsingKnownPort() throws
Exception {
brokerStop();
}
+ public void testCreateTcpConnectionWithSocketParameters() throws Exception
{
+ // Control case: check that the factory can create an ordinary
(non-ssl) connection.
+ String tcpUri =
"tcp://localhost:61610?socket.OOBInline=true&socket.keepAlive=true&tcpNoDelay=true";
+ broker = createBroker(tcpUri);
+
+ // This should create the connection.
+ ActiveMQSslConnectionFactory cf = getFactory(tcpUri);
+ connection = (ActiveMQConnection)cf.createConnection();
+ assertNotNull(connection);
+
+ Transport transport = connection.getTransport();
Review Comment:
Good suggestion. I initially thought about keeping the logic separate as one
test gets a `Socket` and the other gets an `SSLSocket`. A simple check to
determine whether or not to get the superclass makes the helper method fit both
tests though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
