kenliao94 commented on code in PR #1360:
URL: https://github.com/apache/activemq/pull/1360#discussion_r1872048367
##########
activemq-unit-tests/src/test/java/org/apache/activemq/ActiveMQSslConnectionFactoryTest.java:
##########
@@ -103,6 +117,24 @@ public void testCreateSslConnection() throws Exception {
brokerStop();
}
+ public void testCreateSslConnectionWithSocketParameters() throws Exception
{
+ // Create SSL/TLS connection with trusted cert from truststore.
+ String sslUri =
"ssl://localhost:61611?socket.enabledProtocols=TLSv1.3";
+ broker = createSslBroker(sslUri);
+ assertNotNull(broker);
+
+ // This should create the connection.
+ ActiveMQSslConnectionFactory cf = getFactory(sslUri);
+ cf.setTrustStore("server.keystore");
+ cf.setTrustStorePassword("password");
+ connection = (ActiveMQConnection)cf.createConnection();
+ LOG.info("Created client connection");
Review Comment:
Do we need this LOG.info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
