odraese commented on a change in pull request #626: [HIVE-21686] ensure that 
memory allocator does not evict using brute …
URL: https://github.com/apache/hive/pull/626#discussion_r283424857
 
 

 ##########
 File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
 ##########
 @@ -4053,6 +4053,9 @@ private static void 
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
     LLAP_ALLOCATOR_DEFRAG_HEADROOM("hive.llap.io.allocator.defrag.headroom", 
"1Mb",
         "How much of a headroom to leave to allow allocator more flexibility 
to defragment.\n" +
         "The allocator would further cap it to a fraction of total memory."),
+    
LLAP_ALLOCATOR_MAX_FORCE_EVICTED("hive.llap.io.allocator.max.force.eviction", 
"16Mb",
+        "How much bytes we can force evict before using free List discards 
and/or burt force\n" +
 
 Review comment:
   How much bytes -> how many bytes
   burt force -> brute force
   (general: the description isn't very helpful w/o knowing impl. details)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to