odraese commented on a change in pull request #626: [HIVE-21686] ensure that
memory allocator does not evict using brute …
URL: https://github.com/apache/hive/pull/626#discussion_r283529056
##########
File path:
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java
##########
@@ -102,7 +104,7 @@ public void testBuffers() throws Exception {
final int MAX_ALLOC = 64;
LlapDaemonCacheMetrics metrics = LlapDaemonCacheMetrics.create("", "");
BuddyAllocator alloc = new BuddyAllocator(
- false, false, 8, MAX_ALLOC, 1, 4096, 0, null, mm, metrics, null, true);
+ false, false, 8, MAX_ALLOC, 1, 4096, 0, null, mm, metrics, null, true,
1024 * 1024 * 128);
Review comment:
Same here. 128M could be a final static...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
