odraese commented on a change in pull request #626: [HIVE-21686] ensure that
memory allocator does not evict using brute …
URL: https://github.com/apache/hive/pull/626#discussion_r283527108
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/cache/MemoryManager.java
##########
@@ -57,4 +57,13 @@
* allocate the space.
*/
void reserveMemory(long memoryToReserve, AtomicBoolean isStopped);
+
+ /**
+ * Ask the memory manager to evict more memory
+ *
+ * @param memoryToReserve amount of bytes to evict
+ * @return actual amount of evicted bytes.
+ */
+ long evictMemory(long memoryToReserve);
Review comment:
Adding this to MemoryManager kind'o breaks the separation of memory manager
and eviction policy (at least from interface perspective, these were two
separate things so far).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
