odraese commented on a change in pull request #626: [HIVE-21686] ensure that
memory allocator does not evict using brute …
URL: https://github.com/apache/hive/pull/626#discussion_r283426559
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java
##########
@@ -48,6 +48,24 @@
import org.apache.hadoop.hive.llap.metrics.LlapDaemonCacheMetrics;
import org.apache.hadoop.hive.ql.io.orc.encoded.StoppableAllocator;
+/**
+ *
+ * High level description, functionality and the memory layout.
+ * Allocation can be of general size but it will be rounded to the next power
of 2.
+ * Allocation smaller than size {@link ConfVars#LLAP_ALLOCATOR_MIN_ALLOC} will
be rounded to min allocation size.
+ * Allocation bigger than size {@link ConfVars#LLAP_ALLOCATOR_MAX_ALLOC} will
throw exceptions.
+ * Allocator slices memory slab called {@code arenas} to carve out byte
buffers using slice and position.
+ *
+ * Each {@code arena} has array of {@code freeList} used for concurrency
management and to index free buffers by size.
Review comment:
arena -> Arena (also below) - as this is a code reference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
