odraese commented on a change in pull request #626: [HIVE-21686] ensure that
memory allocator does not evict using brute …
URL: https://github.com/apache/hive/pull/626#discussion_r283527581
##########
File path:
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java
##########
@@ -87,7 +91,7 @@ public void testSameSizes() throws Exception {
int min = 3, max = 8, maxAlloc = 1 << max;
BuddyAllocator a = new BuddyAllocator(isDirect, isMapped, 1 << min,
maxAlloc, maxAlloc,
maxAlloc, 0, tmpDir, new DummyMemoryManager(),
- LlapDaemonCacheMetrics.create("test", "1"), null, true);
+ LlapDaemonCacheMetrics.create("test", "1"), null, true, 1024 * 1024 *
128);
Review comment:
You're using this 128MB value multiple times in this suite. Maybe, you want
to move this into a const.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
