kgyrtkirk commented on a change in pull request #550: HIVE-21198 Introduce a
database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r345441875
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/RenameTableHandler.java
##########
@@ -55,18 +55,19 @@
}
}
- String oldName = StatsUtils.getFullyQualifiedTableName(oldDbName,
tableObjBefore.getTableName());
- String newName = StatsUtils.getFullyQualifiedTableName(newDbName,
tableObjAfter.getTableName());
+ TableName oldName = TableName.fromString(tableObjBefore.getTableName(),
null, oldDbName);
+ TableName newName = TableName.fromString(tableObjAfter.getTableName(),
null, newDbName);
ReplicationSpec replicationSpec = context.eventOnlyReplicationSpec();
if (ReplUtils.isTableMigratingToTransactional(context.hiveConf,
tableObjAfter)) {
replicationSpec.setMigratingToTxnTable();
}
- AlterTableRenameDesc renameTableDesc = new AlterTableRenameDesc(oldName,
replicationSpec, false, newName);
+ AlterTableRenameDesc renameTableDesc =
+ new AlterTableRenameDesc(oldName, replicationSpec, false,
newName.getNotEmptyDbTable());
Review comment:
the newName is passed as string; while oldName is a TableName (ok in a
followup as well)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
