kgyrtkirk commented on a change in pull request #550: HIVE-21198 Introduce a
database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r345449867
##########
File path: storage-api/src/java/org/apache/hadoop/hive/common/TableName.java
##########
@@ -86,36 +101,55 @@ public String getTable() {
/**
* Get the name in db.table format, for use with stuff not yet converted to
use the catalog.
+ * Fair warning, that if the db is null, this will return null.tableName
+ * @deprecated use {@link #getNotEmptyDbTable()} instead.
*/
+ // to be @Deprecated
public String getDbTable() {
return db + DatabaseName.CAT_DB_TABLE_SEPARATOR + table;
+ }
+
+ /**
+ * Get the name in `db`.`table` escaped format, if db is not empty,
otherwise pass only the table name.
+ */
+ public String getEscapedNotEmptyDbTable() {
Review comment:
I think these escaper things should live in the exec side; aren't they only
used during unparsing around there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
