kgyrtkirk commented on a change in pull request #550: HIVE-21198 Introduce a
database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r345441151
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/AddPrimaryKeyHandler.java
##########
@@ -53,16 +54,17 @@
return tasks;
}
- String actualDbName = context.isDbNameEmpty() ? pks.get(0).getTable_db() :
context.dbName;
- String actualTblName = pks.get(0).getTable_name();
+ final String actualDbName = context.isDbNameEmpty() ?
pks.get(0).getTable_db() : context.dbName;
+ final String actualTblName = pks.get(0).getTable_name();
+ final TableName tName = TableName.fromString(actualTblName, null,
actualDbName);
Review comment:
can we chane the order of the arguments of this method?
cat, db, tblName instead (can be done in a followup)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
