kgyrtkirk commented on a change in pull request #550: HIVE-21198 Introduce a
database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r345389350
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -1085,7 +1086,7 @@ public void createTable(Table tbl, boolean ifNotExists,
List<SQLCheckConstraint> checkConstraints)
throws HiveException {
try {
- if (tbl.getDbName() == null || "".equals(tbl.getDbName().trim())) {
+ if (org.apache.commons.lang3.StringUtils.isBlank(tbl.getDbName())) {
Review comment:
oh my we are using lang3.StringUtils, lang.StringUtils;
hadoop.common.StringUtils and hadoop.util.StringUtils
might be worth trying to use less ...
(can be fixed in next patch...this is not cruical)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
