kgyrtkirk commented on a change in pull request #550: HIVE-21198 Introduce a
database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r345405314
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -2296,16 +2297,16 @@ private void getMetaData(QB qb, ReadEntity parentInput)
}
if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESTATSAUTOGATHER)) {
// Add the table spec for the destination table.
- qb.getParseInfo().addTableSpec(ts.tableName.toLowerCase(), ts);
+
qb.getParseInfo().addTableSpec(ts.getTableName().getTable().toLowerCase(), ts);
Review comment:
I think this means that we are using only the table's name here; without
database/etc qualification....the patch right now preserves the existing
behaviour; but to be more correct: we should be using either TableName's fqdn
toString - please open a followup; I suspect that this might cause incorrect
behaviour as well; I also think that addTableSpec should accept TableName; and
do this magic there instead of at every call site; I just seen another
`[...].toLowerCase()` line repeated a few lines below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
