jcamachor commented on a change in pull request #960: HIVE-23030 ds rollup union
URL: https://github.com/apache/hive/pull/960#discussion_r397551062
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java
##########
@@ -349,7 +351,7 @@ private static String getName(GenericUDF hiveUDF) {
/**
* This class is used to build immutable hashmaps in the static block above.
*/
- private static class StaticBlockBuilder {
+ private static class StaticBlockBuilder implements Consumer<Pair<String,
SqlOperator>> {
Review comment:
Is the intention to move all function to use this mechanism?
I am also a bit confused since this block does not seem to contain Aggregate
functions. Will we be using same approach for those other aggregate functions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
