kgyrtkirk commented on a change in pull request #960: HIVE-23030 ds rollup union URL: https://github.com/apache/hive/pull/960#discussion_r397697500
########## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/DataSketchesFunctions.java ########## @@ -53,169 +72,256 @@ private static final String SKETCH_TO_VARIANCES = "variances"; private static final String SKETCH_TO_PERCENTILE = "percentile"; - private final Registry system; + private List<SketchDescriptor> sketchClasses; Review comment: I don't really want to make this field static; but making the constructor private and creating a singleton might achieve the same goal (avoid constructing twice) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
