kgyrtkirk commented on a change in pull request #960: HIVE-23030 ds rollup union
URL: https://github.com/apache/hive/pull/960#discussion_r397640132
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java
##########
@@ -349,7 +351,7 @@ private static String getName(GenericUDF hiveUDF) {
/**
* This class is used to build immutable hashmaps in the static block above.
*/
- private static class StaticBlockBuilder {
+ private static class StaticBlockBuilder implements Consumer<Pair<String,
SqlOperator>> {
Review comment:
I didn't wanted to pollute this class with the registering of that stuff -
because registering all agreggates(which are mergeable) for all sketches is a
bit more than just registering a single function
So the registering of the aggregates happens thru the `Consumer.accept()`
invocation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
