kgyrtkirk commented on a change in pull request #960: HIVE-23030 ds rollup union URL: https://github.com/apache/hive/pull/960#discussion_r397637641
########## File path: ql/src/test/queries/clientpositive/sketches_rollup.q ########## @@ -0,0 +1,40 @@ + Review comment: I think this test also belongs to the "sketches" stuff; so I don't think it should be prefixed with `materialized_view`. It does builds upon MV stuff; but primarily its goal is to test the sketches related features - in this case that materialized rollup works; I've renamed it to `sketches_materialized_view_rollup` This is a perfect example that there are test cases which belong to multiple categories....if we want to run them by categories we should address that separately ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
