kgyrtkirk commented on a change in pull request #960: HIVE-23030 ds rollup union
URL: https://github.com/apache/hive/pull/960#discussion_r399266150
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java
##########
@@ -468,6 +470,13 @@ private static String getName(GenericUDF hiveUDF) {
);
registerFunction("date_add", HiveDateAddSqlOperator.INSTANCE,
hToken(HiveParser.Identifier, "date_add"));
registerFunction("date_sub", HiveDateSubSqlOperator.INSTANCE,
hToken(HiveParser.Identifier, "date_sub"));
+
+ DataSketchesFunctions.registerCalciteFunctions(this);
+ }
+
+ @Override
+ public void accept(Pair<String, SqlOperator> t) {
+ registerDuplicateFunction(t.left, t.right, hToken(HiveParser.Identifier,
t.left));
Review comment:
opened HIVE-23091 to investigate if we need that udf name interrogation or
not...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
