soumyakanti3578 commented on PR #4620: URL: https://github.com/apache/hive/pull/4620#issuecomment-1692417128
@jfsii @ayushtkn Currently `SHOW CREATE DATABASE` doesn't add a `;`, however, `EXPLAIN DDL SELECT * FROM TABLE` does, as can be seen [here](https://github.com/apache/hive/blob/master/ql/src/test/results/clientpositive/llap/partition_explain_ddl.q.out#L402). So, for consistency, I will add a semi colon [here](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/ddl/database/showcreate/ShowCreateDatabaseOperation.java#L72). I am also planning to move the closing paren and semicolon `);` to a new line. This will prevent them from getting masked and can then be picked up if q.out files change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
