soumyakanti3578 commented on PR #4620: URL: https://github.com/apache/hive/pull/4620#issuecomment-1692538268
From my experiments, it looks like in Impala `SHOW CREATE TABLE` includes the constraints with the columns, not as `ALTER TABLE` statements, which is the case in Hive. I agree with your points that `;` has not been there since the beginning, however, currently if you do a `SHOW CREATE TABLE`, you get a CREATE statement with no `;`, and then you can get a bunch of ALTERs with semicolons ([example](https://github.com/apache/hive/blob/master/ql/src/test/results/clientpositive/llap/show_create_table.q.out#L114)). `Explain DDL`s also work similarly ([example](https://github.com/apache/hive/blob/master/ql/src/test/results/clientpositive/llap/constraints_explain_ddl.q.out#L102)). I think we should keep these consistent, either all statements should have semi colons or none of them. Having semicolons in all of them helps with copying and pasting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
